unify makefile #103
Merged
unify makefile #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lagovas
requested changes
Nov 1, 2017
| @@ -37,10 +37,13 @@ temp_copy: | |||
| @GOPATH=$(ABS_TEMP_GOPATH) go get github.com/cossacklabs/acra/cmd/... | |||
|
|
|||
|
|
|||
| build: temp_copy | |||
| install: temp_copy | |||
There was a problem hiding this comment.
here make install do not the same as in other our products. here it will copy binaries to REPO_DIR/build (
Line 4 in fa860a2
and after changing path is important to drop this command -
Line 48 in fa860a2
/usr/bin folder when user will run sudo make clean :)
|
as result we decided that it's okay to install acra to the local folder using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unify makefile: add
install,install_all,test_allcommandssimilar to
cossacklabs/themis#248